Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change recheck API to accept recheck data as string #385

Merged
merged 4 commits into from
Nov 29, 2021
Merged

Change recheck API to accept recheck data as string #385

merged 4 commits into from
Nov 29, 2021

Conversation

TysonMN
Copy link
Member

@TysonMN TysonMN commented Nov 27, 2021

Resolves #383

@TysonMN TysonMN requested a review from dharmaturtle November 27, 2021 14:46
@TysonMN
Copy link
Member Author

TysonMN commented Nov 27, 2021

@Sweeney1309, you could also review this

@TysonMN
Copy link
Member Author

TysonMN commented Nov 27, 2021

The Fable build failed, probably because it doesn't have the Base64 functions I used. Probably should just contact strings together for now.

dharmaturtle
dharmaturtle reviewed Nov 28, 2021
View reviewed changes
@TysonMN TysonMN force-pushed the Base64 branch 3 times, most recently from f57199f to 4d6b184 Compare November 28, 2021 02:21
@TysonMN
Copy link
Member Author

TysonMN commented Nov 28, 2021

I removed the use of Base64 (which means that branch name isn't great any more, but whatever), and now the Fable tests pass.

@TysonMN
Copy link
Member Author

TysonMN commented Nov 28, 2021 •
edited
Loading

And I changed the separator to _ so that failure message now looks like this

This failure can be reproduced by running:
> Property.recheck "0_7219121334209301472_6351764504400104151" <property>

dharmaturtle
dharmaturtle approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@dharmaturtle dharmaturtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last typo, but otherwise LGTM!

@TysonMN TysonMN merged commit 5d6bdb0 into hedgehogqa:master Nov 29, 2021
@TysonMN TysonMN deleted the Base64 branch November 29, 2021 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dharmaturtle dharmaturtle dharmaturtle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change recheck functions to accept Base64 encoding
2 participants
@TysonMN @dharmaturtle