Implement Property.select via bind to avoid bug #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Feb 22, 2021
ghost
reviewed
Feb 22, 2021
ghost
reviewed
Feb 22, 2021
ghost
added this to the 
TysonMN
force-pushed
the
317_select_exception_failure
branch
from
89dd3ca to
a1e284d
Compare
ghost
reviewed
Mar 21, 2021
ghost
reviewed
Mar 21, 2021
|
@TysonMN if you can get this rebased I'll merge it |
Co-authored-by: adam-becker <47185607+adam-becker@users.noreply.github.com>
TysonMN
force-pushed
the
317_select_exception_failure
branch
from
91e5034 to
eb515e5
Compare
|
Done |
|
Can you merge now? Hedgehog.Experimental will have a new release soon and it would be nice to have this and the other bug fixes included. |
ghost
merged commit
Sorry for the delay, this has been merged. 🎉 |
|
No problem. Thanks for merging :) |
Merged
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #317
I added tests corresponding to those given in #317 except that they pass when the behavior is correct and fail otherwise. Then I fixed the issue by implementing
Property.selectviaProperty.bindand especiallyProperty.ofThrowing, which maps a thrown exception toOutcome<_>.Failure.