Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

Readme lsp flag #1559

Merged
merged 2 commits into from
Jan 6, 2020
Merged

Readme lsp flag #1559

merged 2 commits into from
Jan 6, 2020

Conversation

Anrock
Copy link
Collaborator

@Anrock Anrock commented Jan 6, 2020

Adds --lsp flag to integration instructions for vim+coc and vim+languageclient
Part of #1558

@fendor fendor requested a review from alanz January 6, 2020 18:12
@alanz alanz merged commit 14523be into haskell:master Jan 6, 2020
@andys8
Copy link
Contributor

andys8 commented Jan 6, 2020

I updated /~https://github.com/neoclide/coc.nvim/wiki/Language-servers#haskell with --lsp. Is this flag mandatory?

Update: It looks like it is. #1538 (comment)

andys8 added a commit to andys8/dotfiles that referenced this pull request Jan 6, 2020
@alanz
Copy link
Collaborator

alanz commented Jan 6, 2020

Yes, it is, to allow dumping human readable debug info it run without it.

@andys8
Copy link
Contributor

andys8 commented Jan 6, 2020

Okay, good to know :)

Maybe too late, but I'd prefer the end-user having no flags - meaning less possibilities to mis-configure the setup. On the other hand, there doesn't seem to be a consistent way for language server configuration anyway (different language server implementations)

@alanz
Copy link
Collaborator

alanz commented Jan 6, 2020

Well, when the end-user is debugging running without flags is a good option. It also mirrors the behaviour in ghcide, so gives some consistency.

It also was the standard for a very long time, only changed recently.

andys8 added a commit to andys8/dotfiles that referenced this pull request Jan 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants