Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

Enable azure releases and some fixes #1545

Merged
merged 38 commits into from
Jan 9, 2020

Conversation

jneira
Copy link
Member

@jneira jneira commented Jan 5, 2020

The history is a liitle bit hairy, maybe it should be squashed.

@jneira jneira requested review from lukel97 and fendor January 5, 2020 00:24
@alanz
Copy link
Collaborator

alanz commented Jan 5, 2020

I am thinking of starting a release process, should I wait for this first?

@fendor
Copy link
Collaborator

fendor commented Jan 5, 2020

I dont think so, the artifacts dont work at the moment, iirc, since we havent solved the problem with hlint yet.
Moreover, azure is still not enaled for our repository, right?

Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
As a minor suggestion, being more verbose might be a good idea, e.g. all tar commads could have the -v flag. That has the advantage that we see what files are compressed or extracted.

.azure/linux-stack.yml Outdated Show resolved Hide resolved
.azure/windows-installhs-cabal.yml Show resolved Hide resolved
@jneira jneira force-pushed the azure-release-win-cache branch from fe92e47 to 7d3a721 Compare January 7, 2020 10:40
@jneira
Copy link
Member Author

jneira commented Jan 7, 2020

After testing we already can use the hlint data file under the same directory of hie executable i've change the scripts to include it:

  • with stack unpack hlint --stack-yaml=../$(YAML_FILE)we'll get the appropiate hlint version

I've added -vto all tar commands as suggested by @fendor

@jneira
Copy link
Member Author

jneira commented Jan 7, 2020

I am thinking of starting a release process, should I wait for this first?

@alanz @fendor i think we could start the release process labeling it as beta after merging this:

  • There is a unofficial azure account named haskell-ide-engine: https://dev.azure.com/haskell-ide-engine/ created by @power-fungus with builds from @power-fungus and @fendor repos
    • Maybe we could connect the default haskell-ide-engine project to @alanz one and use it as the main one until we get permissions to link the haskell org repo (or use fendor's one or mine)
  • We could upload manually all the artifacts to github (until we get to automatically publish the artifacts to github) or/and point to azure releases
  • Testing previously the precompiled binaries in clean environments
  • Waiting for the issues opened by users that want to give a try to them

@alanz
Copy link
Collaborator

alanz commented Jan 7, 2020

I just sent a mail to the haskell committee, who manage the haskell organisation on github, I think.

Hopefully they can do something for us.

@jneira
Copy link
Member Author

jneira commented Jan 8, 2020

I think it could be merged so if nobody disagree i'll do a squash&merge soon

@jneira jneira force-pushed the azure-release-win-cache branch from cc896e6 to 60ff59d Compare January 8, 2020 11:47
@hvr
Copy link
Member

hvr commented Jan 8, 2020

Where do I need to go to enable Azure releases for this repo?

@jneira
Copy link
Member Author

jneira commented Jan 8, 2020

@hvr thanks a lot!

  • I think you might do all from github settings > Integration Services > Azure Pipelines (it navigates to a wizard)
  • In some step it asks how to configure the project an we should choose "Existing Azure Pipelines YAML file"
  • Maybe you could consider invite to The Azure Pipelines Project any of github maintaners with the appropiate permissions: in https://dev.azure.com/${account}/${project} there is a link to do it

let me know if you want more details

@alanz
Copy link
Collaborator

alanz commented Jan 8, 2020

@jneira Given this is a CI PR, which generally has a pretty boring and not useful history, I am ok with a squash merge, if that is what you want to do.

@jneira jneira merged commit 059f354 into haskell:master Jan 9, 2020
@jneira jneira deleted the azure-release-win-cache branch January 13, 2020 06:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants