This repository has been archived by the owner on Oct 7, 2020. It is now read-only.
Use ghc-mod without memory leak #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As fixed by @bubba in alanz/ghc-mod#21
lorenzo
approved these changes
Jun 18, 2019
|
I’d like to change the putMVar calls to non blocking ones just in case before this is merged, will do this tonight! |
Why? There should be no contention for the MVar, if there is, a hangup gives us some kind of warning. |
|
I'll merge as this is already an improvement! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As fixed by @bubba in alanz/ghc-mod#21