Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require head.hackage for GHC 9.10 by default #725

Closed
RyanGlScott opened this issue May 12, 2024 · 2 comments · Fixed by #726
Closed

Don't require head.hackage for GHC 9.10 by default #725

RyanGlScott opened this issue May 12, 2024 · 2 comments · Fixed by #726

Comments

@RyanGlScott
Copy link
Contributor

Currently, generating a CI job for GHC 9.10 will cause it to use head.hackage by default:

          if [ $((HCNUMVER >= 91000)) -ne 0 ] ; then echo "HEADHACKAGE=true" >> "$GITHUB_ENV" ; else echo "HEADHACKAGE=false" >> "$GITHUB_ENV" ; fi

This is a consequence of this code:

defaultHeadHackage :: VersionRange
defaultHeadHackage = C.orLaterVersion (C.mkVersion [9,9])

Now that GHC 9.10.1 is fully released, should this be changed so that 9.10.1 doesn't require head.hackage, just like other full GHC releases?

@phadej
Copy link
Collaborator

phadej commented May 12, 2024

Ouch. Thanks for spotting this! I'll make a fix asap.

@RyanGlScott
Copy link
Contributor Author

Now that GHC 9.12.1 has been released, I think we need to do something similar by defining defaultHeadHackage = C.orLaterVersion (C.mkVersion [9,13]).

RyanGlScott added a commit to RyanGlScott/haskell-ci that referenced this issue Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants