Store Cluster Name in Physical Storage #26878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
marcboudreau
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vault currently displays duplicate and blank cluster labels when deployments are made with k8s.
This is the result of a race condition during the activation of the telemetry system. Telemetry is initialized before Vault is unsealed, therefore it is not able to pull the cluster name and information that is stored in encrypted storage.
To solve this, it was suggested that we store the cluster name in unencrypted storage, so that it can be accessed prior to Vault being unsealed. Vault will then attempt to pull from encrypted storage first, and if it is unable to pull out a valid name, it will then use the value stored in unencrypted storage.