Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: fixed cases where CodeMirror textarea inputs did not have associated labels #26263

Merged
merged 4 commits into from
Apr 5, 2024
Merged

Bug: fixed cases where CodeMirror textarea inputs did not have associated labels #26263

merged 4 commits into from
Apr 5, 2024

Conversation

MelSumner
Copy link
Contributor

@MelSumner MelSumner commented Apr 3, 2024 •
edited
Loading

If merged, this PR:

  • fixes instances where CodeMirror JSON editor components did not have an appropriate label for accessibility compliance.
  • fixes an instance where a label existed for an input but had the incorrect value to be appropriately associated with the input
  • removes label-related TODOs and ember-a11y-testing config from test files (no longer needed); ran tests locally to ensure they pass.

@MelSumner MelSumner marked this pull request as draft April 3, 2024 23:27
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Apr 3, 2024
@MelSumner MelSumner requested a review from andaley April 3, 2024 23:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

Build Results:
All builds succeeded! ✅

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024 •
edited
Loading

CI Results:
All Go tests succeeded! ✅

@andaley andaley added this to the 1.16.2 milestone Apr 4, 2024
@andaley andaley added the ui label Apr 4, 2024
@MelSumner MelSumner changed the title fixes cases where inputs did not have associated labels Bug: fixed cases where CodeMirror textarea inputs did not have associated labels Apr 4, 2024
@MelSumner MelSumner marked this pull request as ready for review April 4, 2024 18:58
andaley
andaley approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@andaley andaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these code changes look great! thank you so much for proactively noticing this problem and adding a fix so quickly. once the build jobs all succeed this looks good to go on my end; go ahead and merge it and i'll make sure it gets included in the next release. 🎉

@hashishaw hashishaw merged commit ce639f8 into main Apr 5, 2024
48 of 54 checks passed
@hashishaw hashishaw deleted the melsumner/a11y-fixes branch April 5, 2024 13:49
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andaley andaley andaley approved these changes

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui
Projects
None yet
Milestone
1.16.2
Development

Successfully merging this pull request may close these issues.
3 participants
@MelSumner @andaley @hashishaw