api: Separate two distinct areas of code that were interleaved in one file #21906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… file This is a code cleanup and addition of an explanatory comment. For some reason, the code related to the CLI guessing whether a path requires sudo, has been interleaved into plugin_helpers.go, which was previously purely code used on the server side in the implementation of Vault plugins. This remedies that by dividing the sudo paths code to a separate file, and adds a comment to plugin_helpers.go providing future readers with information about the overall theme of the file. No code has been changed - only moved and documented.
maxb
commented
Jul 18, 2023
| @@ -33,56 +43,6 @@ const ( | |||
| PluginUnwrapTokenEnv = "VAULT_UNWRAP_TOKEN" | |||
| ) | |||
|
|
|||
| // sudoPaths is a map containing the paths that require a token's policy | |||
There was a problem hiding this comment.
Note to reviewer: All this removed code is moved without change to sudo_paths.go
|
I request |
This was referenced Jul 18, 2023
banks
reviewed
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a code cleanup and addition of an explanatory comment. For some reason, the code related to the CLI guessing whether a path requires sudo, has been interleaved into plugin_helpers.go, which was previously purely code used on the server side in the implementation of Vault plugins.
This remedies that by dividing the sudo paths code to a separate file, and adds a comment to plugin_helpers.go providing future readers with information about the overall theme of the file.
No code has been changed - only moved and documented.