Removed the legacy env var: LOGXI_FORMAT #17822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipherboy
reviewed
Nov 4, 2022
ncabatoff
approved these changes
Nov 4, 2022
cipherboy
approved these changes
Nov 4, 2022
| @@ -60,16 +60,13 @@ func ParseLogFormat(format string) (LogFormat, error) { | |||
| case "json": | |||
| return JSONFormat, nil | |||
| default: | |||
| return UnspecifiedFormat, fmt.Errorf("Unknown log format: %s", format) | |||
| return UnspecifiedFormat, fmt.Errorf("unknown log format: %s", format) | |||
| } | |||
| } | |||
|
|
|||
| // ParseEnvLogFormat parses the log format from an environment variable. | |||
| func ParseEnvLogFormat() LogFormat { | |||
There was a problem hiding this comment.
The one thing that's not immediately clear to me, and probably doesn't need to be answered in this PR, is why is this function necessary?
If we use EnvVar in the StringVar in the command side, do we need to call this as well/alternatively? Or can we just rely on the option variable handling this instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.