Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of OIDC Alternate Path Bug into release/1.10.x #17689

Merged
merged 3 commits into from
Oct 27, 2022

Conversation

zofskeez
Copy link
Contributor

Backport of #17661

* adds error handling to auth-jwt component for missing roles and fixes bug where role wasn't being retained when using alternate oidc mount path at login

* fixes jwt login bug from auth mount tabs and adds test

* updates okta-number-challenge success value to arg in template

* adds changelog entry

* fixes issues logging in manually with jwt

* reverts mistaken change
@zofskeez zofskeez added this to the 1.10.8 milestone Oct 27, 2022
@zofskeez zofskeez enabled auto-merge (squash) October 27, 2022 15:28
Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 Also, thanks for adding that test coverage for the auth-form in your original PR 👏

@hellobontempo hellobontempo added the bug Used to indicate a potential bug label Oct 27, 2022
@zofskeez zofskeez merged commit 10cd851 into release/1.10.x Oct 27, 2022
@hellobontempo hellobontempo deleted the ui/backport-pr-17661-1.10.x branch October 27, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants