Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make google_compute_instance_guest_attributes return empty results when queried for nonexistent values #20760

Conversation

modular-magician
Copy link
Collaborator

closes #20346

  • Removed error thrown on Instances.GetGuestAttributes calls
  • Added additional Instances.Get call to see if the instance exists at all

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: `google_compute_instance_guest_attributes` will return empty arrays and lists when queried values don't exist instead of throwing an error

Derived from GoogleCloudPlatform/magic-modules#12487

…when queried for nonexistent values (hashicorp#12487)

[upstream:55ec2413bf9eee962665d452b46aa629e3252a49]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician requested a review from a team as a code owner December 19, 2024 20:46
@modular-magician modular-magician merged commit 5c2707b into hashicorp:main Dec 19, 2024
4 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_compute_instance_guest_attributes data source returns an error if no attributes matchquery_path
1 participant