Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Network Connectivity Spoke Router and VPN Tunnels #20650

Conversation

modular-magician
Copy link
Collaborator

  • Remove immutable flag from VPN Tunnels to support:
    • includeImportRanges updates
  • Remove immutable flag from Router Appliances to support:
    • Instance count updates
    • includeImportRanges updates
  • Add correct update_mask_fields for VPN Tunnels and Router Appliances
  • Fix Router Appliance instance attributes to be properly marked as required
  • Update tests to verify:
    • Router Appliance scaling from 1 to 2 instances
    • Import range modifications
      Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

networkconnectivity: added support for updating `linked_vpn_tunnels.include_import_ranges`, `linked_interconnect_attachments.include_import_ranges`, `linked_router_appliance_instances. instances` and `linked_router_appliance_instances.include_import_ranges` in `google_network_connectivity_spoke`
networkconnectivity: fixed `linked_router_appliance_instances.instances.virtual_machine` and `linked_router_appliance_instances.instances.ip_address` attributes in `google_network_connectivity_spoke` to be correctly marked as required. Otherwise the request to create the resource will fail.

Derived from GoogleCloudPlatform/magic-modules#12519

…2519)

[upstream:3a54268c0efd6991b9d9763d63742619b8787e9e]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician requested a review from a team as a code owner December 10, 2024 19:11
@modular-magician modular-magician merged commit e7a33c1 into hashicorp:main Dec 10, 2024
4 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant