Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accesscontextmanager - Fix permadiff for perimeter ingress / egress rule resources #20046

Conversation

modular-magician
Copy link
Collaborator

Add diff suppress and custom flatten to fix permadiffs for changing resource orders on the api side. Sometimes the api returns a different order for (ingressTo|egressTo).resources. This change sorts the users config and the api response to always be in the same order to prevent diffs.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

accesscontextmanager: Fixed permadiff for perimeter ingress / egress rule resources

Derived from GoogleCloudPlatform/magic-modules#12119

…ule resources (hashicorp#12119)

Co-authored-by: Charlesleonius <charlesleon@google.com>

[upstream:551f48015dbed65b65a5610cbb41b02f7f801bc6]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 9cff218 into hashicorp:main Oct 25, 2024
4 checks passed
@modular-magician modular-magician deleted the downstream-pr-551f48015dbed65b65a5610cbb41b02f7f801bc6 branch November 17, 2024 00:12
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant