Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix perma-diff on gpu_driver_installation_config for node_config #18835

Conversation

modular-magician
Copy link
Collaborator

Default on driver installation is applied to new node pool creation in GKE 1.30. With this change, the terraform plan shows a diff on gpu_driver_installation_config, which will cause resource recreation.

gpu_driver_installation_config {
  gpu_driver_version = "DEFAULT"
}

This PR will fix the permdiff. More details on b/352610176

Release Note Template for Downstream PRs (will be copied)

container: fixed perma-diff on `node_config.guest_accelerator.gpu_driver_installation_config` field in GKE 1.30+ in `google_container_node_pool` resource

Derived from GoogleCloudPlatform/magic-modules#11152

…hicorp#11152)

[upstream:175fd710586d855bdede46688edf5a07db6715a4]

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 6be2fb7 into hashicorp:main Jul 24, 2024
4 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2024
@modular-magician modular-magician deleted the downstream-pr-175fd710586d855bdede46688edf5a07db6715a4 branch November 17, 2024 00:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant