Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add type to security policy #10764

Closed

Conversation

jasondamour
Copy link

@github-actions github-actions bot requested a review from ScottSuarez December 15, 2021 23:12
go.mod Outdated Show resolved Hide resolved
@ScottSuarez
Copy link
Collaborator

Waiting for response to aucampia's questions before reviewing myself

@jasondamour
Copy link
Author

@ScottSuarez @aucampia Addressed all comments, can you please review again? Specifically, is there somewhere I didn't add code that needs it? Thanks

go.mod Outdated Show resolved Hide resolved
Copy link
Collaborator

@ScottSuarez ScottSuarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll need to send this field on create... see line 215 for how we send rule.. We will need to do something similar for type.

Did you test this locally?

Can you add a test at /~https://github.com/hashicorp/terraform-provider-google/blob/master/google/resource_compute_security_policy_test.go

@ManojPachigolla
Copy link

@aucampia Even, I was stuck with this option "type" to make use of the security policy for GCS backend.
Any timeline for this feature addition to include the option type in "google_compute_security_policy"

Thanks

modular-magician added a commit to modular-magician/terraform-provider-google that referenced this pull request Jul 10, 2024
)

[upstream:b8a463edcd5a423613ca5aa1adf95f59095c2d73]

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit that referenced this pull request Jul 10, 2024
)

[upstream:b8a463edcd5a423613ca5aa1adf95f59095c2d73]

Signed-off-by: Modular Magician <magic-modules@google.com>
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants