-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add type to security policy #10764
feat: add type to security policy #10764
Conversation
Waiting for response to aucampia's questions before reviewing myself |
@ScottSuarez @aucampia Addressed all comments, can you please review again? Specifically, is there somewhere I didn't add code that needs it? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you'll need to send this field on create... see line 215 for how we send rule
.. We will need to do something similar for type
.
Did you test this locally?
Can you add a test at /~https://github.com/hashicorp/terraform-provider-google/blob/master/google/resource_compute_security_policy_test.go
@aucampia Even, I was stuck with this option "type" to make use of the security policy for GCS backend. Thanks |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
#10761