Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Tls Inspection Policy resource and update Gateway Security Policy to use the field tlsInspectionPolicy #5615

Merged
merged 1 commit into from
May 9, 2023
Merged

Create Tls Inspection Policy resource and update Gateway Security Policy to use the field tlsInspectionPolicy #5615

merged 1 commit into from
May 9, 2023

Conversation

modular-magician
Copy link
Collaborator

Creating the TlsInspectionPolicy.
Adding the field tlsInspectionPolicy in the resource GatewaySecurityPolicies and one basic test for this scenario.

fixes: hashicorp/terraform-provider-google#14479

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

`google_network_security_gateway_security_policy`
`google_network_security_tls_inspection_policy`

Derived from GoogleCloudPlatform/magic-modules#7880

@modular-magician
Create Tls Inspection Policy resource and update Gateway Security Pol…
cd62cf1 
…icy to use the field `tlsInspectionPolicy` (hashicorp#7880)

* adding the resources, the examples and the tests

* updates in the tsl resource, added fix in the tests files, but not creating the tls resource, just the ca pool

* adding a todo for certificate authority

* adding the resource of certificate, need to fix the error while deleting

* fixed the creation of ca and capool, receiving error 13 for tls creation

* removing advanced example, adding capool fields for tests, failing in tls creation

* updating the ca_pool to add into the tls, not working

* fix the tests, concurrency problem, solved with depends_on field

* updating the gateway security policy to use tls inpection policy

* fixing the test scenario for tls_inspection basic

* fix a typo in documentation for tls resource and the name of file test

* adding a new field in the resource and in the test scenario, adding a todo for a field with a resource not implemented

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 6f2fbc0 into hashicorp:main May 9, 2023
@modular-magician modular-magician deleted the downstream-pr-e681d0a36afd09b7517ddb7821c52efc156291f8 branch November 16, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create TLS Inpection Policy and Enhancement of Gateway Security Policy.
1 participant
@modular-magician