Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifact Registry: add virtual repository and remote repository support #5289

Conversation

modular-magician
Copy link
Collaborator

This PR adds support for virtual repositories and remote repositories to google-beta.

Resolves #hashicorp/terraform-provider-google#13536

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

artifactregistry: added field `virtual_repository_config` and `remote_repository_config` to `google_artifact_registry_repository` (beta)

Derived from GoogleCloudPlatform/magic-modules#7333

…rt (hashicorp#7333)

* Artifact Registry: Virtual + Remote Repositories

* Artifact Registry: Examples + beta v1 endpoint

* Artifact Registry: Removed unused fields from examples

* Artifact Registry: Generate missing exactly_one_of fields

* Artifact Registry: Input-only RR field + Handwritten update tests

* Artifact Registry: Input-only propagation

* Artifact Registry: proper merge

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 152de40 into hashicorp:main Mar 6, 2023
@modular-magician modular-magician deleted the downstream-pr-2fb7c9cb1a7792ed636a66c98b28675ded1f5698 branch November 16, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant