Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added instance_type field to google_sql_database_instance resource #5057

Conversation

modular-magician
Copy link
Collaborator

This PR is in effort to fix hashicorp/terraform-provider-google#11424

Buganizer ticket Id : b/259900473

I have added a compute only attribute instance_type in google_sql_database_instance resource. This field already exist in the instance object in admin api. https://cloud.google.com/sql/docs/mysql/admin-api/rest/v1beta4/instances

This field is necessary during update API calls, so that the API could distinguish between a regular instance and read replica instance.

sql: added `instance_type` field to `google_sql_database_instance` resource

Derived from GoogleCloudPlatform/magic-modules#7044

@modular-magician modular-magician merged commit 80d21b9 into hashicorp:main Jan 6, 2023
@modular-magician modular-magician deleted the downstream-pr-3b2cd9f8717cdd3aa9267ecfa2bb24b40bcc7e45 branch November 16, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot update Cloud SQL read replica instance with binary logging enabled
1 participant