Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filter nil #4956

Merged
merged 1 commit into from
Dec 6, 2022
Merged

filter nil #4956

merged 1 commit into from
Dec 6, 2022

Conversation

modular-magician
Copy link
Collaborator

Fixes: hashicorp/terraform-provider-google#13174

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

cloud composer: fixed a crash when updating `ip_allocation_policy` of `google_composer_environment`

Derived from GoogleCloudPlatform/magic-modules#6916

@modular-magician
filter nil (hashicorp#6916)
5b05029 
Co-authored-by: Edward Sun <sunedward@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 8023c05 into hashicorp:main Dec 6, 2022
modular-magician added a commit to modular-magician/terraform-provider-google-beta that referenced this pull request Dec 20, 2022
@modular-magician @gsancewicz
Support new features of IGM.updatePolicy (hashicorp#4956) (hashicorp#…
32b6889 
…4235)

* Add new IGM.UpdatePolicy features - minimal_action=REFRESH and most_disruptive_allowed_action

* Fix documentation of most_disruptive_allowed_action

* Make most_disruptive_allowed_action an Optional field.

* Fix RMIG UpdatePolicy flattening.

* Fix most_disruptive_allowed_action documentation - new field is Optional.

* Fix most_disruptive_allowed_action documentation - and improve testing.

* Fix whitespaces in test.

Co-authored-by: Grzegorz Sancewicz <gsancewicz@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: Grzegorz Sancewicz <gsancewicz@google.com>
modular-magician added a commit to modular-magician/terraform-provider-google-beta that referenced this pull request Dec 20, 2022
@modular-magician
Revert "Support new features of IGM.updatePolicy (hashicorp#4956)" (h…
a2c8d22 
…ashicorp#5964) (hashicorp#4247)

This reverts commit 31d1d1663e8b5912730cb7009b379c338bad3723.

Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician added a commit to modular-magician/terraform-provider-google-beta that referenced this pull request Dec 20, 2022
@modular-magician @khajduczenia
Adds support for Graceful Updater in Compute Managed Instance Groups. (…
4b21c14 
…hashicorp#5975) (hashicorp#4282)

* Support new features of IGM.updatePolicy (hashicorp#4956)

* Add new IGM.UpdatePolicy features - minimal_action=REFRESH and most_disruptive_allowed_action

* Fix documentation of most_disruptive_allowed_action

* Make most_disruptive_allowed_action an Optional field.

* Fix RMIG UpdatePolicy flattening.

* Fix most_disruptive_allowed_action documentation - new field is Optional.

* Fix most_disruptive_allowed_action documentation - and improve testing.

* Fix whitespaces in test.

Co-authored-by: Grzegorz Sancewicz <gsancewicz@google.com>

* Always send minimal_action and most_disruptive_allowed_action with IGM.UpdatePolicy.

* Make minimal_action optional and send null values instead of empty strings

* Remove unnecesary appending to ForceSendFields array

* Fix documentation for minimal_action - field is no longer required.

* Revert making minimal_action optional.

Co-authored-by: Kamil Hajduczenia <khajduczenia@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>

Co-authored-by: Kamil Hajduczenia <khajduczenia@google.com>
@modular-magician modular-magician deleted the downstream-pr-0042aba87326e5903f5348808f8eb89a71163bcb branch November 16, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: The terraform-provider-google_v4.44.1_x5 plugin crashed! - Composer environment creation
1 participant
@modular-magician