Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added parameter region to google_vertex_ai_featurestore_entitytype #4845

Conversation

modular-magician
Copy link
Collaborator

fixes hashicorp/terraform-provider-google#10100 : "google_vertex_ai_featurestore_entitytype: Cannot determine region: set in this resource, or set provider-level 'region' or 'zone' #10100.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

vertex_ai:  made google_vertex_ai_featurestore_entitytype always use regional endpoint corresponding to parent's region

Derived from GoogleCloudPlatform/magic-modules#6588

…pe (hashicorp#6588)

* fix: added parameter region to google_vertex_ai_featurestore_entitytype

* Revert "fix: added parameter region to google_vertex_ai_featurestore_entitytype"

This reverts commit ddf67919b021469c9f3e4593426bfedd127cd6fb.

* fix: extract region from the featurestore id

* fix: add custom_import for the region field

* fix: 2nd attempt to fix the custom_import override

* fix: 3rd attempt to fix the custom_import for the region field

* fix: 4th attempt to fix the custom_import for the region field

* fix: reverted the custom_import back

* fix: use the right import code for the custom_import

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 1d11969 into hashicorp:main Nov 7, 2022
@modular-magician modular-magician deleted the downstream-pr-25eabe69d0c21e391689ec031375c4572d2399d7 branch November 16, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant