Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fields related to health checked targets to dns_record_set resource #4816

Conversation

modular-magician
Copy link
Collaborator

This resource used to support two types of routing policies: weighted round robin (wrr) and geo location (geo). Now we will be supporting a third option: primary-backup.

In addition, the existing routing types are being updated in two ways:

  • enabled_geo_fencing is being added to support fencing behavior of all geo items
  • health_checked_targets is being added to both wrr and geo, which provides another option for configuring the routing behavior

All together, this work aims to support health checking capabilities for internal load balancers.

b/239887327

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

dns: added `primary_backup` to `routing_policy` block of `google_dns_record_set` resource
dns: added `enable_geo_fencing` to `routing_policy` block of `google_dns_record_set` resource
dns: added `health_checked_targets` to `wrr` and `geo` blocks of `google_dns_record_set` resource

Derived from GoogleCloudPlatform/magic-modules#6665

…ce (hashicorp#6665)

Co-authored-by: Shuya Ma <shuyama@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@shuyama1 shuyama1 merged commit 0eef5b8 into hashicorp:main Oct 23, 2022
googlerjk pushed a commit to googlerjk/terraform-provider-google-beta that referenced this pull request Oct 24, 2022
…ce (hashicorp#6665) (hashicorp#4816)

Co-authored-by: Shuya Ma <shuyama@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>

Signed-off-by: Modular Magician <magic-modules@google.com>
Co-authored-by: Shuya Ma <shuyama@google.com>
@modular-magician modular-magician deleted the downstream-pr-00669b0558b186b0a29106bbccbd58b3cfdf554d branch November 16, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants