Add certificate_map to compute_target_https_proxy #4550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add certificate_map to compute_target_https_proxy * ENH rename s/certificateMaps/certificateMap since we only set one map ENH improve description by adding the specific required format ENH: use exactly_one_of instead of at_least_one_of BF fix missing correctly /global path in the update_url * Adding example and test for certificate_map * Remove 'beta' flag from certificateMap Improve certificate manager tests * Splitting target https proxy update and certificate tests into separate tests Fix typo in certificate manager certificate map entry full test * Revert certificate manager certificate map entry full test Add correct prefix to certificate_map within compute target https proxy test Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
deleted the
downstream-pr-d8fd7ce3c5162c53ae8c102d4ff75f97392224ae
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to issue hashicorp/terraform-provider-google#11037
Add certificate_map option to compute_target_https_proxy in order to support new certificate-manager (with wildcard support).
If this PR is for Terraform, I acknowledge that I have:
make testandmake lintto ensure it passes unit and linter tests.Derived from GoogleCloudPlatform/magic-modules#5991