Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for userflow resource #892

Closed
wants to merge 6 commits into from

Conversation

jarifibrahim
Copy link

@jarifibrahim jarifibrahim commented Sep 27, 2022

This PR depends on manicminer/hamilton#179

This PR adds support for Create/Read/Update/Delete operations for b2c user flow via azuread provider.

NOTE: This PR build will fail until a new version of /~https://github.com/manicminer/hamilton is released.

TODO

  • Support Update
  • Support Delete
  • Add tests

@jarifibrahim jarifibrahim marked this pull request as ready for review September 29, 2022 12:52
@jarifibrahim jarifibrahim changed the title [WIP] Add support for userflow resource Add support for userflow resource Sep 29, 2022
@manicminer manicminer marked this pull request as draft September 29, 2022 20:09
@jarifibrahim jarifibrahim marked this pull request as ready for review September 30, 2022 06:58
@manicminer
Copy link
Contributor

Hi @jarifibrahim, thanks for submitting this! Apologies for the delay in reviewing. I've made some changes to get this ready for merging, but unfortunately I do not have access to push to the PR branch. I am therefore going to close this PR and open a new one so I can get those changes ready. For future contributions, I would recommend submitting the PR from a fork in your own user account, rather than another organization. Thanks again for working on this!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants