Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vendor directory #633

Merged
merged 2 commits into from
Jun 9, 2021
Merged

Remove vendor directory #633

merged 2 commits into from
Jun 9, 2021

Conversation

dnephin
Copy link
Contributor

@dnephin dnephin commented Jun 9, 2021

Branched from #632

The vendor directory is not up-to-date. Running go mod vendor shows files
are updated. Since this package has been using Go modules for a while now we
no longer need the vendor directory.

@dnephin dnephin requested a review from a team June 9, 2021 17:15
@dnephin dnephin force-pushed the dnephin/update-ci branch from 1cd04fb to ac85eef Compare June 9, 2021 17:20
The vendor directory is not up-to-date. Running 'go mod vendor' shows files
are updated. Since this package has been using Go modules for a while now we
no longer need the vendor directory.
@rboyer
Copy link
Member

rboyer commented Jun 9, 2021

There's one teeny reference to vendor in GNUMakefile you might want to remove while you're at it:

GNUmakefile:GOFILES ?= $(shell go list ./... | grep -v /vendor/)

@dnephin
Copy link
Contributor Author

dnephin commented Jun 9, 2021

Good call, removed it from the makefile

Base automatically changed from dnephin/update-ci to master June 9, 2021 21:41
Copy link
Member

@rboyer rboyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnephin dnephin merged commit baf0ccf into master Jun 9, 2021
@dnephin dnephin deleted the dnephin/remove-vendor branch June 9, 2021 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants