feat: Wrap modularized code in transactionExecutionService #9943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…codeTracer Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
kselveliev
requested review from
bilyana-gospodinova,
nickeynikolovv,
IvanKavaldzhiev,
sdimitrov9 and
steven-sheehy
kselveliev
changed the title
| @@ -2,6 +2,7 @@ hedera: | |||
| mirror: | |||
| web3: | |||
| evm: | |||
| modularizedServices: false | |||
There was a problem hiding this comment.
This is not needed as by the default the value is false.
There was a problem hiding this comment.
Correct, comment addressed
Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
…e-service Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
| if (isContractCreate) { | ||
| // Upload the init bytecode | ||
| transactionBody = buildFileCreateTransactionBody(params, maxLifetime); | ||
| var uploadReceipt = executor.execute(transactionBody, Instant.EPOCH); |
There was a problem hiding this comment.
Do we need this call? What if we use the next available FileID in the mirror node, as a value?
There was a problem hiding this comment.
This can be addressed in the base PR since this pr is just copy paste the code from the modularized property pr
Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
…e-service Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
steven-sheehy
approved these changes
Dec 16, 2024
|
Merging any other changes will be addressed in the #9927 PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR wraps modularized execution and logic into it's own standalone
TransactionExecutionService.Doing this the adaptation of the
OpcodeServiceTestarguments and result captors becomes incredibly easy.Also added opcodeTracer when the call is coming from an opcode call.
Main changes:
Added
TransactionExecutionServiceclassWhich contains the new modularized execution logic in itself. The code is moved from
ContractCallServiceintoTransactionExecutionServicewith the only addition of the opcodeTracer if the opcode tracer options are set.AbstractContractCallServiceOpcodeTracerTest- now check based on the modularized feature flag to capture arguments and result either frommirrorEvmTxProcessor.executeortransactionExecutionService.executeTransactionExecutionServiceTest- adds coverage for the newly created class.Fixes #9830
Notes for reviewer:
Checklist