Add file id and init bytecode in ContractCallContext
#9799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
bilyana-gospodinova
changed the title
ContractCallContext
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
steven-sheehy
requested changes
Dec 11, 2024
hedera-mirror-web3/src/main/java/com/hedera/mirror/web3/common/ContractCallContext.java
Outdated
Show resolved
Hide resolved
hedera-mirror-web3/src/main/java/com/hedera/mirror/web3/state/FileReadableKVState.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
…798-enhance-FileReadableKVState-to-fetch-contract-from-ContractCallContext
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
…te-and-subcomponents
steven-sheehy
previously approved these changes
Dec 11, 2024
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
kselveliev
reviewed
Dec 12, 2024
hedera-mirror-web3/src/main/java/com/hedera/mirror/web3/common/ContractCallContext.java
Outdated
Show resolved
Hide resolved
kselveliev
previously approved these changes
Dec 12, 2024
Base automatically changed from
09791-init-mirror-node-state-and-subcomponents
to
main
December 12, 2024 14:47
steven-sheehy
dismissed
kselveliev’s stale review
The base branch was changed.
…dableKVState-to-fetch-contract-from-ContractCallContext
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9799 +/- ##
=========================================
Coverage 92.24% 92.24%
- Complexity 7830 7832 +2
=========================================
Files 953 953
Lines 32759 32766 +7
Branches 4142 4143 +1
=========================================
+ Hits 30217 30225 +8
Misses 1568 1568
+ Partials 974 973 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
|
steven-sheehy
approved these changes
Dec 12, 2024
steven-sheehy
deleted the
09798-enhance-FileReadableKVState-to-fetch-contract-from-ContractCallContext
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
During the implementation of the reusable services integration it turns out that now the contracts are deployed in 2 steps:
FileCreateTransactionBody.ContractCreateTransactionBody.Each step performs a separate transaction.
For step 2 even if we pass the correct file id, since the mirror node data is readonly, the
FileReadableKVStateis not able to populate the contract's bytecode from the DB since it was never explicitly persisted in the DB.This PR add a new field in the
ContractCallContextthat preserve the file id and the contract's bytecode. The new field is called "file". If it is available when we callFileReadableKVState#readFromDataSourcethen we return the file from the context with priority.This field might need to be cleared up at some point but this will probably added later when the correct place is found during testing.
Fixes #9798