Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add schema registry and migrator components #9710

Merged
merged 37 commits into from
Nov 18, 2024
Merged

Add schema registry and migrator components #9710

merged 37 commits into from
Nov 18, 2024

Conversation

kselveliev
Copy link
Contributor

@kselveliev kselveliev commented Nov 5, 2024 •
edited by steven-sheehy
Loading

Description:
This PR adds subcomponents needed for reusable services -
ServicesRegistryImpl, SchemaRegistryImpl and ServiceMigratorImpl components

This PR adds:
ServicesRegistryImpl class similar to FakeServicesRegistry in services + unit tests
SchemaRegistryImpl class similar to FakeSchemaRegistry in services + unit tests
ServiceMigratorImpl class similar to FakeServiceMigrator in services + unit tests

Related issue(s):

Fixes #9260

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

bilyana-gospodinova and others added 7 commits November 4, 2024 14:39
@bilyana-gospodinova
Implement MirrorNodeState
ce8ef43 
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
@kselveliev
feat: Add schema registry component for reusable services
804eae1 
Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
@kselveliev
feat: Add service migrator similar to services
e00abba 
Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
@bilyana-gospodinova
Implement MirrorNodeState
dda0c80 
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
@bilyana-gospodinova
Add dynamic service configuration
7b1d58d 
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
@kselveliev
Merge branch '09259-state-implementation' into 09260-add-schema-regis…
b67223f 
…try-component

Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
@kselveliev
fix: Uncomment needed lines in schema registry after state changes
dd72bd0 
Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
@kselveliev kselveliev requested a review from a team as a code owner November 5, 2024 14:33
@kselveliev kselveliev self-assigned this Nov 5, 2024
@kselveliev kselveliev added the web3 Area: Web3 API label Nov 5, 2024
@steven-sheehy steven-sheehy added the enhancement Type: New feature label Nov 5, 2024
@steven-sheehy steven-sheehy added this to the 0.118.0 milestone Nov 5, 2024
@steven-sheehy steven-sheehy changed the title 09260- Add schema registry and migrator components Add schema registry and migrator components Nov 5, 2024
steven-sheehy
steven-sheehy requested changes Nov 5, 2024
View reviewed changes
...-mirror-web3/src/main/java/com/hedera/mirror/web3/state/components/ServicesRegistryImpl.java Outdated Show resolved Hide resolved
...ra-mirror-web3/src/main/java/com/hedera/mirror/web3/state/components/SchemaRegistryImpl.java Outdated Show resolved Hide resolved
...ra-mirror-web3/src/main/java/com/hedera/mirror/web3/state/components/SchemaRegistryImpl.java Show resolved Hide resolved
...ra-mirror-web3/src/main/java/com/hedera/mirror/web3/state/components/SchemaRegistryImpl.java Show resolved Hide resolved
...ra-mirror-web3/src/main/java/com/hedera/mirror/web3/state/components/SchemaRegistryImpl.java Show resolved Hide resolved
...a-mirror-web3/src/main/java/com/hedera/mirror/web3/state/components/ServiceMigratorImpl.java Show resolved Hide resolved
...ra-mirror-web3/src/main/java/com/hedera/mirror/web3/state/components/SchemaRegistryImpl.java Show resolved Hide resolved
...ra-mirror-web3/src/main/java/com/hedera/mirror/web3/state/components/SchemaRegistryImpl.java Show resolved Hide resolved
@kselveliev
fix: Refactor migrator and networkInfo for successful state initializ…
c2702b7 
…ation

Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
@kselveliev
fix: Addressing review comments
5dded46 
Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
kselveliev and others added 7 commits November 8, 2024 17:15
@kselveliev
fix: Addressing review comments
cceb9e5 
Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
@bilyana-gospodinova
Implement MirrorNodeState
b38d57d 
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
@bilyana-gospodinova
Add dynamic service configuration
f1e940e 
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
@bilyana-gospodinova
Fix code smell
ea49673 
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
@bilyana-gospodinova
Increase code coverage
2b598bf 
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
@bilyana-gospodinova
sync with services more
f0d9d34 
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
@bilyana-gospodinova
Update the state as in example
cd96150 
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
@bilyana-gospodinova
Fix code smells and improve coverage
2fede4f 
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
@bilyana-gospodinova
Fix code smells
afcf416 
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
@kselveliev
Merge branch '09259-state-implementation' into 09260-add-schema-regis…
b8ae0f0 
…try-component

Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
@steven-sheehy steven-sheehy modified the milestones: 0.118.0, 0.119.0 Nov 11, 2024
@bilyana-gospodinova
Implement MirrorNodeState
afbf84a 
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
@bilyana-gospodinova
Add dynamic service configuration
90e20a1 
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
@bilyana-gospodinova
Fix code smell
7917a71 
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
@bilyana-gospodinova
Increase code coverage
8c730bb 
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
@bilyana-gospodinova
sync with services more
d7b3da2 
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
@bilyana-gospodinova
Update the state as in example
8fe36b1 
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
@bilyana-gospodinova
Fix code smells and improve coverage
532e291 
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
@bilyana-gospodinova
Fix code smells
5116cba 
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
@bilyana-gospodinova
Fix PR comments
49cdcfb 
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
@bilyana-gospodinova
Improve coverage
bdefa11 
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
@bilyana-gospodinova
Increase coverage
fa57b07 
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
bilyana-gospodinova and others added 3 commits November 12, 2024 13:31
@bilyana-gospodinova
Increase coverage (again)
28a2912 
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
@bilyana-gospodinova
Rename packages
b724cbb 
Signed-off-by: Bilyana Gospodinova <bilyana.gospodinova14@gmail.com>
@kselveliev
Merge branch '09259-state-implementation' into 09260-add-schema-regis…
18e6dd0 
…try-component

Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
Base automatically changed from 09259-state-implementation to main November 15, 2024 16:06
@kselveliev
Merge branch 'main' into 09260-add-schema-registry-component
9715335 
Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
@codecov Codecov
Copy link

codecov bot commented Nov 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.93814% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.27%. Comparing base (8a78609) to head (7feac7d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rror/web3/state/components/SchemaRegistryImpl.java 96.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #9710      +/-   ##
============================================
- Coverage     92.35%   92.27%   -0.09%     
- Complexity     7635     7766     +131     
============================================
  Files           927      948      +21     
  Lines         32085    32437     +352     
  Branches       4083     4113      +30     
============================================
+ Hits          29632    29930     +298     
- Misses         1496     1543      +47     
- Partials        957      964       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@kselveliev
fix: Remove duplicated classes
7f32049 
Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
@kselveliev
fix: Fix code smells
62d40fa 
Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
@kselveliev
fix: Fix code smells
7feac7d 
Signed-off-by: Kristiyan Selveliev <kristiyan.selveliev@limechain.tech>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

bilyana-gospodinova
bilyana-gospodinova approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@bilyana-gospodinova bilyana-gospodinova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit ea0cb0a into main Nov 18, 2024
34 checks passed
@steven-sheehy steven-sheehy deleted the 09260-add-schema-registry-component branch November 18, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bilyana-gospodinova bilyana-gospodinova bilyana-gospodinova approved these changes

@steven-sheehy steven-sheehy steven-sheehy approved these changes

@IvanKavaldzhiev IvanKavaldzhiev Awaiting requested review from IvanKavaldzhiev

Assignees

@kselveliev kselveliev

Labels
enhancement Type: New feature web3 Area: Web3 API
Projects
None yet
Milestone
0.119.0
Development

Successfully merging this pull request may close these issues.

Add needed subcomponents for State initialization
3 participants
@kselveliev @steven-sheehy @bilyana-gospodinova