Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final protobuf & bump to v0.5.1-rc1 #492

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Conversation

steven-sheehy
Copy link
Member

Detailed description:

  • Replaces temporary hedera-protobuf with Maven Central official release 0.4.0
  • Removes deprecated response code
  • Bumps version to v0.5.1-rc1
  • Increases r2dbc connection pool max size to 25 based upon testing
  • Clarifies comments about max proto size being 6KiB not 4KiB

Which issue(s) this PR fixes:
Fixes #490

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@steven-sheehy steven-sheehy added enhancement Type: New feature P1 process Build or test related tasks labels Jan 9, 2020
@steven-sheehy steven-sheehy added this to the Mirror 0.5.1 milestone Jan 9, 2020
@steven-sheehy steven-sheehy requested a review from Nana-EC January 9, 2020 20:26
@steven-sheehy steven-sheehy self-assigned this Jan 9, 2020
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 85e968f into master Jan 9, 2020
@steven-sheehy steven-sheehy deleted the hcs-proto-final branch January 9, 2020 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature P1 process Build or test related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Final HCS protobuf
2 participants