Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix entities duplicate key violation #484

Merged
merged 1 commit into from
Jan 3, 2020

Conversation

steven-sheehy
Copy link
Member

Detailed description:

Which issue(s) this PR fixes:
Fixes #483

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@steven-sheehy steven-sheehy added bug Type: Something isn't working P1 parser Area: File parsing labels Jan 3, 2020
@steven-sheehy steven-sheehy added this to the Mirror 0.5.1 milestone Jan 3, 2020
@steven-sheehy steven-sheehy requested a review from Nana-EC January 3, 2020 22:41
@steven-sheehy steven-sheehy self-assigned this Jan 3, 2020
@codecov
Copy link

codecov bot commented Jan 3, 2020

Codecov Report

Merging #484 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #484      +/-   ##
============================================
- Coverage     60.68%   60.64%   -0.04%     
+ Complexity      101      100       -1     
============================================
  Files            78       78              
  Lines          2673     2673              
  Branches        341      341              
============================================
- Hits           1622     1621       -1     
  Misses          899      899              
- Partials        152      153       +1
Impacted Files Coverage Δ Complexity Δ
...irror/importer/parser/record/RecordFileLogger.java 83.72% <100%> (ø) 0 <0> (ø) ⬇️
...era/mirror/grpc/listener/PollingTopicListener.java 93.75% <0%> (-3.13%) 11% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be8ff52...a4070ae. Read the comment docs.

Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit cf1b42d into master Jan 3, 2020
@steven-sheehy steven-sheehy deleted the duplicate-key-violation branch January 3, 2020 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working P1 parser Area: File parsing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate Key Violation on entities
2 participants