Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add demo bucket as default #441

Merged
merged 1 commit into from
Dec 12, 2019
Merged

Add demo bucket as default #441

merged 1 commit into from
Dec 12, 2019

Conversation

steven-sheehy
Copy link
Member

Detailed description:

  • Sets default bucket and network to demo
  • Adds new demo addressbook (same as testnet)
  • Simplifies docker-compose startup
  • Provides instructions on how to pass custom application.yml to docker-compose

Which issue(s) this PR fixes:
Fixes #435

Special notes for your reviewer:
Production uses explicit setting for bucket and network, so no migration needed.

Checklist

  • Documentation added
  • Tests updated

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@steven-sheehy steven-sheehy added enhancement Type: New feature P1 downloader Area: S3 downloader labels Dec 11, 2019
@steven-sheehy steven-sheehy added this to the Mirror 0.5.0 milestone Dec 11, 2019
@steven-sheehy steven-sheehy self-assigned this Dec 11, 2019
@steven-sheehy steven-sheehy merged commit f35bd6a into master Dec 12, 2019
@steven-sheehy steven-sheehy deleted the demo-bucket branch December 12, 2019 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
downloader Area: S3 downloader enhancement Type: New feature P1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new demo bucket as default
3 participants