Upgrade to Spring Boot 2.2 #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
steven-sheehy
added
enhancement
steven-sheehy
requested review from
apeksharma,
mike-burrage-hedera and
Nana-EC
Nana-EC
previously approved these changes
Nov 21, 2019
| @@ -52,6 +54,7 @@ public static final Connection getConnection() { | |||
| return dataSource.getConnection(); | |||
| } catch (Exception e) { | |||
| log.warn("Unable to connect to database: {}", e.getMessage()); | |||
| Uninterruptibles.sleepUninterruptibly(100, TimeUnit.MILLISECONDS); | |||
There was a problem hiding this comment.
nit: add a comment on the need for the sleep and chosen time
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
apeksharma
reviewed
Nov 22, 2019
src/main/java/com/hedera/mirror/migration/V1_11_6__Missing_Entities.java
Show resolved
Hide resolved
apeksharma
approved these changes
Nov 22, 2019
Nana-EC
approved these changes
Nov 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description:
@ConfigurationPropertiesWhich issue(s) this PR fixes:
Fixes #329
Special notes for your reviewer:
Checklist