Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize Java packages #378

Merged
merged 4 commits into from
Nov 15, 2019
Merged

Standardize Java packages #378

merged 4 commits into from
Nov 15, 2019

Conversation

steven-sheehy
Copy link
Member

Detailed description:

  • Moves all classes under com.hedera.mirror
  • Consolidates util classes into com.hedera.mirror.util
  • Removes some unused files

Which issue(s) this PR fixes:
Fixes #185
Fixes #339

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@steven-sheehy
Standardize Java packages
335fe76 
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@steven-sheehy
Delete unused EventStreamAnalytics
0526e48 
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
Nana-EC
Nana-EC previously approved these changes Nov 15, 2019
View reviewed changes
Copy link
Collaborator

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mike-burrage-hedera
mike-burrage-hedera suggested changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@mike-burrage-hedera mike-burrage-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing I saw was a few places where the imports are now not sorted. If that isn't important then dismiss my review and LGTM.

src/main/java/com/hedera/mirror/parser/event/EventStreamFileParser.java Outdated Show resolved Hide resolved
src/main/java/com/hedera/mirror/parser/balance/AccountBalancesFileLoader.java Outdated Show resolved Hide resolved
src/main/java/com/hedera/mirror/parser/record/RecordFileLogger.java Outdated Show resolved Hide resolved
src/main/java/com/hedera/mirror/parser/record/RecordFileParser.java Outdated Show resolved Hide resolved
@steven-sheehy
Organize imports
688b6c4 
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@steven-sheehy
Organize imports
0f4ee27 
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@mike-burrage-hedera mike-burrage-hedera merged commit 18303a0 into master Nov 15, 2019
@mike-burrage-hedera mike-burrage-hedera deleted the standardize-packages branch November 15, 2019 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mike-burrage-hedera mike-burrage-hedera mike-burrage-hedera approved these changes

@Nana-EC Nana-EC Nana-EC left review comments

@apeksharma apeksharma Awaiting requested review from apeksharma

Assignees
No one assigned
Labels
enhancement Type: New feature P1 technical debt
Projects
None yet
Milestone
Mirror 0.4.0
Development

Successfully merging this pull request may close these issues.

Standardize package naming Repo cleanup - remove scripts, unused test data
3 participants
@steven-sheehy @mike-burrage-hedera @Nana-EC