Fix CircleCI failures #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
steven-sheehy
added
bug
steven-sheehy
requested review from
apeksharma,
mike-burrage-hedera and
Nana-EC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description:
CircleCI has been failing every other build and causing PRs to not pass. The issue was due to
NetworkAddressBookhaving references to an olderMirrorPropertiesand the tests inRecordFileLoggerFileTestthat were specifically checking for the address book were failing. Fixed by making methods inNetworkAddressBooknon-static. Also madeRecordFileLoggera bean and rely upon spring initialization to assign the static addressbook in its class.Also update the README to add Code of Conduct and a blurb about contributing.
Which issue(s) this PR fixes:
Fixes #375
Special notes for your reviewer:
Don't use static variables for mutable data. Ever.
Checklist