-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS SDKv2 Followup #360
AWS SDKv2 Followup #360
Conversation
Ignore test failures. Like all other PRs, failing tests are from two flaky ones in RecordFileLoggerContractTest. |
src/main/java/com/hedera/mirror/downloader/CommonDownloaderProperties.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Apekshit Sharma <apekshit.sharma@hedera.com>
Signed-off-by: Apekshit Sharma <apekshit.sharma@hedera.com>
Codecov Report
@@ Coverage Diff @@
## master #360 +/- ##
=========================================
Coverage ? 56.07%
Complexity ? 445
=========================================
Files ? 57
Lines ? 2568
Branches ? 332
=========================================
Hits ? 1440
Misses ? 977
Partials ? 151
Continue to review full report at Codecov.
|
Signed-off-by: Apekshit Sharma <apekshit.sharma@hedera.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Apekshit Sharma apekshit.sharma@hedera.com
Which issue(s) this PR fixes:
Addresses #314 partially.
Special notes for your reviewer:
Followup of PR #347.
Checklist