Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS SDKv2 Followup #360

Merged
merged 3 commits into from
Nov 13, 2019
Merged

AWS SDKv2 Followup #360

merged 3 commits into from
Nov 13, 2019

Conversation

apeksharma
Copy link
Contributor

@apeksharma apeksharma commented Nov 7, 2019

Signed-off-by: Apekshit Sharma apekshit.sharma@hedera.com

Which issue(s) this PR fixes:
Addresses #314 partially.

Special notes for your reviewer:
Followup of PR #347.

Checklist

  • Documentation added
  • Tests updated

@apeksharma apeksharma self-assigned this Nov 7, 2019
@apeksharma apeksharma added this to the Hedera Mirror Node 0.4.0 milestone Nov 7, 2019
@apeksharma apeksharma added bug Type: Something isn't working downloader Area: S3 downloader enhancement Type: New feature P1 labels Nov 7, 2019
@apeksharma
Copy link
Contributor Author

Ignore test failures. Like all other PRs, failing tests are from two flaky ones in RecordFileLoggerContractTest.

Signed-off-by: Apekshit Sharma <apekshit.sharma@hedera.com>
Signed-off-by: Apekshit Sharma <apekshit.sharma@hedera.com>
@codecov
Copy link

codecov bot commented Nov 12, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@fb16459). Click here to learn what that means.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #360   +/-   ##
=========================================
  Coverage          ?   56.07%           
  Complexity        ?      445           
=========================================
  Files             ?       57           
  Lines             ?     2568           
  Branches          ?      332           
=========================================
  Hits              ?     1440           
  Misses            ?      977           
  Partials          ?      151
Impacted Files Coverage Δ Complexity Δ
.../mirror/downloader/CommonDownloaderProperties.java 93.33% <100%> (ø) 6 <1> (?)
.../com/hedera/mirror/downloader/PendingDownload.java 65.51% <50%> (ø) 4 <0> (?)
.../java/com/hedera/mirror/downloader/Downloader.java 81.59% <84.61%> (ø) 28 <0> (?)
.../hedera/mirror/config/MirrorNodeConfiguration.java 93.93% <87.5%> (ø) 5 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb16459...ffc0e65. Read the comment docs.

Signed-off-by: Apekshit Sharma <apekshit.sharma@hedera.com>
Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit bea856a into master Nov 13, 2019
@steven-sheehy steven-sheehy deleted the sdkv2 branch November 13, 2019 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working downloader Area: S3 downloader enhancement Type: New feature P1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants