Generate valid secp256k1 key during key creation #10051
Merged
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sdimitrov9 <stoyan.dimitrov@limechain.tech>
sdimitrov9
force-pushed
the
9984-fix-contract-call-service-precompile-modification-tests
branch
from
d3483f1 to
d7d6ee1
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10051 +/- ##
============================================
- Coverage 92.24% 92.23% -0.01%
Complexity 7856 7856
============================================
Files 956 956
Lines 32918 32918
Branches 4153 4153
============================================
- Hits 30364 30363 -1
Misses 1579 1579
- Partials 975 976 +1 ☔ View full report in Codecov by Sentry. |
steven-sheehy
approved these changes
Jan 6, 2025
hedera-mirror-common/src/test/java/com/hedera/mirror/common/domain/DomainBuilder.java
Show resolved
Hide resolved
steven-sheehy
deleted the
9984-fix-contract-call-service-precompile-modification-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Valid secp256k1 key values should start with 0x02 or 0x03 indicating the y-coordinate of the elliptic curve being odd or even.
The change is fixing 6 integration tests as of PR opening.
Related issue(s): 9984
Fixes #
Checklist