Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add C knucleotide program #224

Merged
merged 4 commits into from
Jan 15, 2022
Merged

Add C knucleotide program #224

merged 4 commits into from
Jan 15, 2022

Conversation

JZerf
Copy link
Contributor

@JZerf JZerf commented Jan 3, 2022

This program should be considerably faster than the current fastest program and this should also use noticeably less memory as well.

It looks like there currently is an existing problem where programs that use OpenMP (like this one as well as apparently the existing binarytrees and spectralnorm programs) have linking issues when used with "zig cc". Because of this issue, I added commented out entries for this program to the bench_c_zig.yaml file and also included a short comment about the linking issue so people know why it was commented out. Adding "-lomp5" to the app.rsp file might fix this issue but I'm new to this project and how it works plus I'm not much of an expert at dealing with linking issues so I didn't want to try fixing this yet.

@hanabi1224 hanabi1224 enabled auto-merge (squash) January 14, 2022 05:07
@hanabi1224
Copy link
Owner

hanabi1224 commented Jan 14, 2022

Thanks, but looks like it has some kind of dead lock or very bad performance. The C tests used to finish in 3~5 seconds
image

Update: the problem here takes file input instead of stdin, I believe that's what causes deadlock

@hanabi1224 hanabi1224 disabled auto-merge January 14, 2022 05:11
@JZerf
Copy link
Contributor Author

JZerf commented Jan 15, 2022

Sorry about that. You're right about it reading from stdin instead of the file that was specified as a command line argument. I was having a little trouble at first getting the build step to work and then forgot that there were test and bench steps that I should have ran too so I didn't see that it had a problem. I've made a new commit to correct the program.

On a side note, on my computer the test and bench steps displayed an error saying that an operation was not permitted while trying to add the execute permission to the GCC compiled program. I checked the file afterwards and it was owned by root and already had the execute permission. Other than that it looks like both steps completed successfully.

@hanabi1224 hanabi1224 merged commit c93511f into hanabi1224:main Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants