Migrate tests to Mocha #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,11 @@ | |||
| // Via http://www.asbjornenge.com/wwc/testing_react_components.html | |||
| module.exports = function(markup) { | |||
| if (typeof document !== 'undefined') return; | |||
There was a problem hiding this comment.
What's going on with this check?
There was a problem hiding this comment.
I'd guess it's there to make this a no-op in a real browser.
There was a problem hiding this comment.
Ah I see the attribution now, makes sense.
|
Awesome! LGMT % travis + a few comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name says it all. High order bits:
@globalfeature mucks with the node.js module cache & fundamentally breaks React, which expects to only be loaded once.@jsxin it. I tried renaming all our components to.jsx, but this made node-inspector less pleasant.sinonfor stubs andassertfor tests. We can use something fancier likechaiif you prefer.Tests run a lot faster now, and hopefully less flakily!
Fixes #128