Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove plugins js #2346

Merged
merged 5 commits into from
Sep 30, 2020
Merged

Remove plugins js #2346

merged 5 commits into from
Sep 30, 2020

Conversation

roblarsen
Copy link
Member

closes #2345

@roblarsen roblarsen self-assigned this Sep 28, 2020
@roblarsen roblarsen requested a review from coliff September 28, 2020 18:44
@roblarsen
Copy link
Member Author

(this is based off of #2341, just for clarity of history, I'll merge that first)

sthiepaan
sthiepaan reviewed Sep 29, 2020
View reviewed changes
Copy link
Contributor

@sthiepaan sthiepaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we remove jQuery Library from the project, shouldn't we also remove all the references across the whole project? 🤔 I can see them in:

  • .github/
  • dist/doc/
  • src/doc/
  • .htaccess
  • gulpfile.babel.js
  • humans.txt

@roblarsen
Copy link
Member Author

@sthiepaan #2348

sthiepaan
sthiepaan approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@sthiepaan sthiepaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roblarsen roblarsen merged commit 379789f into master Sep 30, 2020
@coliff coliff deleted the remove-plugins-js branch September 30, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sthiepaan sthiepaan sthiepaan approved these changes

@coliff coliff Awaiting requested review from coliff

Assignees

@roblarsen roblarsen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do we still need plugins.js ?
2 participants
@roblarsen @sthiepaan