-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider using SHA-256 over MD5 for the config file #56
Comments
@silverwind I'm down for that. I also assume our cacheing is fragile here because we are supposed to continue even if a cache error occurs, but that's a different problem. |
It should be a simple swap of |
This seems like a reasonable request - want to send a PR @silverwind ? Should be non-breaking. |
Fixed a maximum line length eslint warning on this line as well. Fixes: gulpjs#56
Fixed a maximum line length eslint warning on this line as well. This change doubles the length of the file name from a previous 32 hex characters to 64. Fixes: gulpjs#56
Bump, I could really use this fix in a project. It is breaking the project when enforcing FIPS when enforcing FIPS because MD5 is not FIPS compliant @silverwind @phated |
/~https://github.com/gulpjs/v8flags/blob/master/index.js#L19 contains a MD5 usage. When Node.js is built with FIPS compliance, that line triggers below error because MD5 is disabled in those builds:
Consider using something more collision-resistant like SHA-256 instead.
The text was updated successfully, but these errors were encountered: