Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "netty:Auto adjust BDP ping frequency" #9821

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Revert "netty:Auto adjust BDP ping frequency" #9821

merged 1 commit into from
Jan 13, 2023

Conversation

larry-safran
Copy link
Contributor

Reverts #9650

@larry-safran larry-safran requested a review from ejona86 January 13, 2023 18:11
@larry-safran larry-safran enabled auto-merge (squash) January 13, 2023 18:12
ejona86
ejona86 approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide more details and references, so that we know why we did this.

At the very least a link to the bug would be appropriate.

@larry-safran larry-safran merged commit a2bbe84 into master Jan 13, 2023
@ejona86 ejona86 deleted the revert-9650-bdp-ping-backoff branch January 13, 2023 19:18
@larry-safran
Copy link
Contributor Author

The change being rolled back caused a 20% wall clock increase in the blaze build of prenotcalculator b/264426890

larry-safran added a commit that referenced this pull request Jan 18, 2023
@larry-safran
Revert "Revert "netty:Auto adjust BDP ping frequency (#9650)" (#9821)"
6fd9983 
This reverts commit a2bbe84.
@larry-safran larry-safran mentioned this pull request Jan 18, 2023
Merged
larry-safran added a commit that referenced this pull request Jan 19, 2023
@larry-safran
Restore "netty:Auto adjust BDP ping frequency" with fix (#9847)
3cbd948 
* Revert "Revert "netty:Auto adjust BDP ping frequency (#9650)" (#9821)"

This reverts commit a2bbe84.

* Eliminate half RTT delay in sending BDP Pings when starting up.
* Eliminate delay for bdp ping when current read would push us over the threshold.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larry-safran @ejona86