xds: fix the EDS dups test so it doesn't assume address order #9786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ejona86 - could you confirm if we should care about the order in the error (status) description? We could use the ordered multiset if we want to make it deterministic. |
larry-safran
reviewed
Jan 4, 2023
| + "addresses: Address: FakeSocketAddress-server1, count: 2; " | ||
| + "Address: FakeSocketAddress-server2, count: 3"); | ||
| String description = result.getStatus().getDescription(); | ||
| assertThat(description).startsWith( |
There was a problem hiding this comment.
This isn't really needed. If someone decides to change the text in the future that is fine.
There was a problem hiding this comment.
We're always on the fence whether error messages should be tested. Anyway, I've noticed it after merging :)
larry-safran
approved these changes
Jan 4, 2023
|
The order doesn't matter. I added the detail of which addresses and the count of them for convenience of debugging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
RingHashLoadBalancerTest.duplicateAddresses()test.Multiset entries are not ordered. This PR updates the test so it's not assuming the order of addresses in the error message.