Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: remove obsolete xDS transport custom dialer option #8079

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

yousukseung
Copy link
Contributor

@yousukseung yousukseung commented Feb 12, 2025

This PR removes #7586 which was made obsolete with #7997.

RELEASE NOTES: N/A

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.15%. Comparing base (0003b4f) to head (35eeea2).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8079      +/-   ##
==========================================
- Coverage   82.32%   82.15%   -0.17%     
==========================================
  Files         387      387              
  Lines       39064    39062       -2     
==========================================
- Hits        32159    32092      -67     
- Misses       5593     5639      +46     
- Partials     1312     1331      +19     
Files with missing lines Coverage Δ
internal/xds/bootstrap/bootstrap.go 65.72% <ø> (-0.20%) ⬇️

... and 23 files with indirect coverage changes

@arjan-bal arjan-bal requested a review from easwars February 17, 2025 07:17
@arjan-bal arjan-bal added Type: Internal Cleanup Refactors, etc Area: xDS Includes everything xDS related, including LB policies used with xDS. labels Feb 17, 2025
@arjan-bal arjan-bal added this to the 1.71 Release milestone Feb 17, 2025
@arjan-bal arjan-bal requested a review from purnesh42H February 17, 2025 07:18
@easwars easwars assigned yousukseung and unassigned easwars and purnesh42H Feb 18, 2025
@easwars easwars merged commit ddb2484 into grpc:master Feb 18, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: xDS Includes everything xDS related, including LB policies used with xDS. Type: Internal Cleanup Refactors, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants