Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: improve documentation of target strings #8078

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Feb 11, 2025

RELEASE NOTES:

  • client: improve documentation of NewClient and CanonicalTarget by providing examples.

@dfawley dfawley added the Type: Documentation Documentation or examples label Feb 11, 2025
@dfawley dfawley added this to the 1.71 Release milestone Feb 11, 2025
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.29%. Comparing base (0003b4f) to head (4f5c3aa).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8078      +/-   ##
==========================================
- Coverage   82.32%   82.29%   -0.03%     
==========================================
  Files         387      387              
  Lines       39064    39064              
==========================================
- Hits        32159    32148      -11     
- Misses       5593     5600       +7     
- Partials     1312     1316       +4     
Files with missing lines Coverage Δ
clientconn.go 90.29% <ø> (ø)

... and 22 files with indirect coverage changes

@easwars easwars assigned dfawley and unassigned easwars Feb 14, 2025
@dfawley dfawley merged commit 91eb6aa into grpc:master Feb 14, 2025
15 checks passed
janardhanvissa pushed a commit to janardhanvissa/grpc-go that referenced this pull request Feb 15, 2025
@dfawley dfawley deleted the doc branch February 25, 2025 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Documentation or examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants