weightedtarget: return erroring picker when no targets are configured #8070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8070 +/- ##
==========================================
+ Coverage 82.10% 82.18% +0.08%
==========================================
Files 387 387
Lines 39067 39080 +13
==========================================
+ Hits 32076 32118 +42
+ Misses 5662 5639 -23
+ Partials 1329 1323 -6
|
dfawley
approved these changes
Feb 10, 2025
| @@ -323,6 +364,11 @@ func (s) TestWeightedTarget(t *testing.T) { | |||
| if state != connectivity.TransientFailure { | |||
| t.Fatalf("Empty target update should have triggered a TF state update, got: %v", state) | |||
| } | |||
| p = <-cc.NewPickerCh | |||
| const wantErr = "no targets to pick from" | |||
| if _, err := p.Pick(balancer.PickInfo{}); !strings.Contains(err.Error(), wantErr) { | |||
There was a problem hiding this comment.
If err is nil this will panic.
Suggested change
| if _, err := p.Pick(balancer.PickInfo{}); !strings.Contains(err.Error(), wantErr) { | |
| if _, err := p.Pick(balancer.PickInfo{}); err == nil || !strings.Contains(err.Error(), wantErr) { |
Or
if _, err := p.Pick(balancer.PickInfo{}); !strings.Contains(fmt.Sprint(err), wantErr) {
easwars
force-pushed
the
weighted_target_error_picker
branch
from
1947074 to
22ad462
Compare
janardhanvissa
pushed a commit
to janardhanvissa/grpc-go
that referenced
this pull request
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the
weighted_targetLB policy wherein it was queueing RPCs even though it was setting the overall connectivity state toTRANSIENT_FAILURE.RELEASE NOTES:
UNAVAILABLEwhen the EDS resource is missing or contains no endpoints