Add optional flag to run edge endpoint for balena #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0d35bcf.
f-wright
changed the title
honeytung
reviewed
Aug 12, 2024
| @@ -53,6 +55,12 @@ check_pv_conflict() { | |||
| return 0 | |||
| } | |||
|
|
|||
| if [ -n "$BALENA" ] && [ -z "$RUN_EDGE_ENDPOINT" ]; then | |||
There was a problem hiding this comment.
Just curious when running on devices in Balena, does this env var "BALENA" get automatically set from them or do we have to do that ourselves?
There was a problem hiding this comment.
The BALENA var is automatically set. We need to go in and set RUN_EDGE_ENDPOINT for it to launch edge-endpoint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires the
RUN_EDGE_ENDPOINTenvironment variable to be set before launching the edge-endpoint pods when running on Balena. A PR in the glhub repo will soon enable running an app and edge-endpoint on a hub device, but we don't want to launch edge-endpoint on the hub devices unless it is specifically enabled.