Fix post_image_query Endpoint
#11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robotrapta
approved these changes
Jul 20, 2023
app/api/endpoints/image_queries.py
Outdated
| @@ -43,19 +36,14 @@ async def post_image_query( | |||
| ) | |||
|
|
|||
| if motion_detected or iq_response_is_improvable: | |||
There was a problem hiding this comment.
I don't remember the iq_response_is_improvable logic. The name is confusing, and I don't think the logic is correct. We shouldn't make motion-detection decisions based on the confidence of the server response.
| @@ -43,19 +36,14 @@ async def post_image_query( | |||
| ) | |||
|
|
|||
| if motion_detected or iq_response_is_improvable: | |||
| image_query = gl.submit_image_query(detector=detector_id, image=image, wait=wait_time) | |||
|
|
|||
| # Store the cloud's response so that if the next image has no motion, we will return | |||
Comment on lines
+20
to
+21
| detector_id: str, | ||
| wait: float = None, |
There was a problem hiding this comment.
Seems like we could still benefit from pydantic modeling here, right? Check that wait is actually a float not a string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows us to pass raw bytes to the
post_image_queryendpoint. Previously, we were encoding bytes into a base64 string and using the Pydantic validator decorator to get bytes from the encoded string. That was problematic because the SDK just works with bytes and we want to have the exact same interface on the edge.