PK-929 Stub edge API #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+9
to
+22
| # Goal: If the request path isn't found in the local edge server, fall back to the API server. | ||
| # TODO: This fallback almost works, but not quite. nginx seems to only do the fallback if | ||
| # the local server is down (502 status code); it doesn't seem to work with "regular" 404s at | ||
| # the application level. I'm not sure how to make it work ... | ||
| # https://nginx.org/en/docs/http/ngx_http_core_module.html#error_page | ||
| location / { | ||
| proxy_pass http://localhost:8080; | ||
| error_page 404 = @fallback; | ||
| } | ||
|
|
||
| location @fallback { | ||
| # TODO: switch to prod | ||
| proxy_pass https://api.integ.groundlight.ai; | ||
| } |
There was a problem hiding this comment.
Any ideas on this bug, @robotrapta?
sunildkumar
reviewed
Dec 20, 2022
| @@ -0,0 +1,97 @@ | |||
| # Build args | |||
| ARG APP_PORT=8080 | |||
There was a problem hiding this comment.
So in this case, 8080 is the port the customer would send queries too?
sunildkumar
reviewed
Dec 20, 2022
| @@ -0,0 +1,97 @@ | |||
| # Build args | |||
There was a problem hiding this comment.
I appreciate all of the comments on this file. It seems in tune with making this open source.
sunildkumar
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stub edge server (FastAPI + Docker + nginx). If a route is implemented in the edge server, then it tries to use the edge server. Otherwise, proxy the request to the real groundlight API endpoint.
Note: there is no application logic implemented (e.g. near-image deduplication on the edge) - it's just a stub.