Adding support for quadrature in Float32 precision
#840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #840 +/- ##
=======================================
Coverage 88.32% 88.33%
=======================================
Files 164 164
Lines 19108 19113 +5
=======================================
+ Hits 16878 16884 +6
+ Misses 2230 2229 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@kishore-nori ! Thanks for your work. Can you please add an entry to the NEWS.md file? |
|
Thank you for checking Alberto. Done! (sorry forgot |
amartinhuertas
approved these changes
Oct 20, 2022
|
@fverdugo ... do you want to comment on this PR? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @amartinhuertas and @fverdugo, I have added support to include a keyword argument
TintoMeasure,CellQuadratureandQuadrature, to perform numerical integration in the desired floating-point precision, in particular,Float32usage. Tests have been added to for checks withFloat32option for all the effected modules.This partially resolves the issue #789 for the quadrature part. The setup of
FESpaceat places seems hard-coded inFloat64, and the floating-point type is not being taken frommodelandreffeconstructed usingFloat32precisions, which I leave for later.This doesn't break the high-level API, as the optional
kwargTdefaults toFloat64. The usage is as follows:Would be happy to know to comments and suggestions for changes and improvements.