Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix in reference_grid(TET) #734

Merged
merged 1 commit into from
Dec 31, 2021
Merged

Bugfix in reference_grid(TET) #734

merged 1 commit into from
Dec 31, 2021

Conversation

pmartorell
Copy link
Collaborator

Dear @fverdugo ,
this an small bugfix on the changes introduced in #704

The new tests also checks that only the boundary facets have one single cell around.

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2021

Codecov Report

Merging #734 (eb8fbab) into master (b25cf8b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #734   +/-   ##
=======================================
  Coverage   88.39%   88.39%           
=======================================
  Files         132      132           
  Lines       15454    15454           
=======================================
  Hits        13660    13660           
  Misses       1794     1794           
Impacted Files Coverage Δ
src/Geometry/Grids.jl 87.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b25cf8b...eb8fbab. Read the comment docs.

@fverdugo
Copy link
Member

@pmartorell Thanks for the fix. Have a nice new year's eve!

@fverdugo fverdugo merged commit 735391b into master Dec 31, 2021
@fverdugo fverdugo deleted the reference_grid_bug branch December 31, 2021 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants